dotnet-podcasts
dotnet-podcasts copied to clipboard
Cleanup
Cleanup:
- Split classes into separate files
- Fixed logging perf issues, avoided interpolated messages, and instead used format.
- Consistent file-scoped namespaces.
- Use
GlobalUsings
where it makes sense. - Use
readonly record struct
instead ofrecord
(orrecord class
) where possible. - Delete redundant CODE_OF_CONDUCT(2).md file.
- Make classes
sealed
where applicable. - Use pattern matching where it makes sense for readability and succinctness.
- Consistent naming of request objects.
- Use HTTPS alternative URLs for RSS feeds when seeding DB data, where possible.
- A bit more CSS for the recently added playback rate control.
@IEvangelist could you do this pr into release/next-steps branch instead of main branch. @jamesmontemagno what do you think?
@migueBarrera switched but lots of conflicts. Any reason not to just merge the next-steps stuff into main? nothing really breaking correct?
next-steps has a lot of changes from the last few weeks.. @IEvangelist made his changes in main instead of next-steps. The other PR from daniel it was me who resolved the conflicts with next-steps. I can do it with this PR again, I know all the changes. Also, I can merge next-steps over main and we avoid these problems again.
the next-steps branch has been merged into main. @IEvangelist you need resolve conflicts. I can't do it, it's in a repo of yours.
the next-steps branch has been merged into main. @IEvangelist you need resolve conflicts. I can't do it, it's in a repo of yours.
Done...
Hey @jamesmontemagno - are we good to merge this one?
@IEvangelist just changed to merge to main, can you re-validate stuff for me.
@IEvangelist just changed to merge to main, can you re-validate stuff for me.
Hey @jamesmontemagno - done
@jamesmontemagno I'm curious, why was this closed? I've been doing everything that you've asked of me on this one. :octocat:
I've already contributed several features to this app and would love to know what happened here.
- I've previously added the playback rate controls that were originally missing.
- I've also provided an initial effort, which was lots of C# and Blazor clean-up, and I added a system theme support.
This PR adds a ton of value and addressed a lot of inconsistencies with how some of this stack is now documented. ☹️ Could you please let me know what needs to be improved upon, or changed?
Would someone please progress this PR? Thanks.