dotnet-apiport icon indicating copy to clipboard operation
dotnet-apiport copied to clipboard

considers Newtonsoft.Json to be available on Core, but not on Desktop.

Open danmoseley opened this issue 7 years ago • 4 comments

I ran it on the desktop version of the dll in this package: https://www.nuget.org/packages/Microsoft.AspNet.WebApi.Client/5.2.3

It says it's 100% compatible with .NET Standard and .NET Core - which is great. But it says it's only 89.7% compatible with .NET Framework. Which makes no sense as it's a .NET Framework asset.

It looks like it considers Newtonsoft.Json to be available on Core, but not on Desktop.

danmoseley avatar Sep 20 '17 23:09 danmoseley

image I have the same problem.

ustcltx avatar Oct 04 '17 04:10 ustcltx

I have Newtonsoft.Json 11.0.2 in my repo, used in a project that runs .NET Framework 4.6 in production. Newtonsoft.Json.JsonConvert, Newtonsoft.Json.Linq.JObject, and Newtonsoft.Json.JsonPropertyAttribute are getting incorrectly flagged as "Not Supported" in .NET Framework 4.6.

I ran this using the Visual Studio Extension.

Paqi avatar Jan 09 '19 18:01 Paqi

@rabrahamOpti This is an a false negative. The issue is with the catalog. (see: https://apisof.net/catalog/Newtonsoft.Json)

It is not part of the .NET Framework, but was ingested for some of the targets. You can ignore this.

@terrajobst Is there any way we can remove this assembly from the catalog? It produces many false negatives.

conniey avatar Jan 09 '19 20:01 conniey

To reduce the confusion, .NET Framework has been removed from the default Target Platforms list for porting scenario since the porting is primarily for estimating the API gap from .NET Framework to .NET Core platforms anyway. It is not the root solution, but for improving customer experience with default setting.

Lxiamail avatar Jul 19 '19 21:07 Lxiamail

Closing as API Port was deprecated in favor of binary analysis in .NET Upgrade Assistant.

terrajobst avatar Nov 15 '22 23:11 terrajobst