devicescript icon indicating copy to clipboard operation
devicescript copied to clipboard

Published 20 hours ago • verified publisher icon microsoft

Number functions

Open pelikhan opened this issue 1 year ago • 8 comments

More support for https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isInteger

pelikhan avatar Jun 23 '23 15:06 pelikhan

HI @pelikhan I am interested to work on this issue. Can you please assign to me and share more details about the use case and how we can test it ? Thanks

ArchitGajjar avatar Jun 23 '23 23:06 ArchitGajjar

I started a little guide at https://microsoft.github.io/devicescript/contributing#add-core-javascript-apis

Is this enough to get you started?

pelikhan avatar Jun 24 '23 16:06 pelikhan

Yes, thank you!

ArchitGajjar avatar Jul 04 '23 07:07 ArchitGajjar

https://github.com/microsoft/devicescript/pull/608

pelikhan avatar Aug 15 '23 16:08 pelikhan

If my PR #665 was good, I'm starting making rest

PiotrKasperski avatar Dec 01 '23 06:12 PiotrKasperski

Focused changes, lots of tests, excellent PR!

pelikhan avatar Dec 01 '23 15:12 pelikhan

Hi @pelikhan, Can someone still worked this issue, I notice @PiotrKasperski has already done a lot of work on this, most especially with rest to the Number class static methods (#669). I will like to contribute with the Number class instance properties and methods implementation

Marcjazz avatar Jan 24 '24 14:01 Marcjazz

We are definitely more contributions! Always welcome. 🙏

pelikhan avatar Jan 24 '24 14:01 pelikhan