devhomegithubextension icon indicating copy to clipboard operation
devhomegithubextension copied to clipboard

Make Review Requested widget editable

Open T-Gro opened this issue 1 year ago • 2 comments

Suggested new feature or improvement

I am not happy with the default GitHub 'review requested' widget configuration in DevHome. I would want a 'review requested && all checks passing && ...' change, as an example. The generic mechanism could be for entering either an existing URL or query parameters into the widgets, using the same notation as they are used on GitHub web.

Scenario

The GitHub widget would come with a default query, but it would be editable.

Additional details

This is an example of a query I use daily and would love to see as the result of a widget load:

is:pr is:open draft:false status:success -reviewed-by:@me

T-Gro avatar May 25 '23 12:05 T-Gro

I believe this has been fixed. If you're still not able to get this working, please let us know!

cinnamon-msft avatar Nov 09 '23 21:11 cinnamon-msft

@cinnamon-msft is correct that you can do this with the Pull Requests widget, instead of the Review Requested widget. Having the ability to configure the Review Requested widget is an interesting idea, but I worry it would duplicate too much functionality from the PR widget. If we change to configuration via drop-down instead of pasted query, I think it gets more compelling.

It's a valid bug, though, that not everything from the query above works -- the PRs returned on GitHub.com are fewer than what I see in Dev Home. I opened https://github.com/microsoft/devhomegithubextension/issues/280.

krschau avatar Nov 17 '23 20:11 krschau