devhome icon indicating copy to clipboard operation
devhome copied to clipboard

Add loading progress ring to the dashboard view while loading widgets

Open aksoftware98 opened this issue 2 years ago • 2 comments

Summary of the pull request

Add a loading progress ring control to the dashboard page while loading the widgets. Current Dashboard pages stays blank for a bit before rendering the widgets

Loading Progress for the Widgets

References and relevant issues

Not sure if #595 is the same issue as in the code, I saw it's mentioned to add that in a TODO comment that references another closed issue and used this. as I think 595 is for the loading inside the widget itself but referenced that just in case.

Detailed description of the pull request / Additional comments

  • Add the ProgressRing UI control to the DashboardView.xaml
  • Set the Visibility property to Visible of the ProgressRing in the OnLoaded() in the code-behind file of DashboardView.xaml
  • Set the Visibility property to Collapsed of the ProgressRing in the OnLoaded() in the code-behind file of DashboardView.xaml

Validation steps performed

Manual testing

PR checklist

  • [ ] Closes #xxx
  • [ ] Tests added/passed
  • [ ] Documentation updated

aksoftware98 avatar May 25 '23 20:05 aksoftware98

@microsoft-github-policy-service agree

aksoftware98 avatar May 25 '23 20:05 aksoftware98

This is awesome, thanks for submitting this PR! (By the way, you're correct that 595 was intended to mean loading inside the widget itself)

krschau avatar Jun 06 '23 22:06 krschau

Excuse me for closing and re-opening this PR, I think I need to do it to get the new build checks working properly since it was opened before they were in place...

krschau avatar Jun 06 '23 23:06 krschau

Excuse me for closing and re-opening this PR, I think I need to do it to get the new build checks working properly since it was opened before they were in place...

It's okay, the checks failed but my branch was a bit behind, I merged main and pushed again

aksoftware98 avatar Jun 07 '23 15:06 aksoftware98

cycling PR to get check kicked off

crutkas avatar Jun 07 '23 22:06 crutkas