devhome icon indicating copy to clipboard operation
devhome copied to clipboard

Storing plugin name

Open dhoehna opened this issue 2 years ago • 6 comments

Summary of the pull request

A recent change was made to store the provider name (Github) and not the plugin name (Dev Home Github Extension)

Eric and I went over the RepoTool and changed all references to make sure Github was shown in the UI.

I missed one. When selecting repos to show from the previous selected repos I search based on the provider name. I compare the provider name in CloningInformation to the provider name in the provider drop down.

The provider name in CloningInformation is Github and the provider name DevHome is comparing against is "Dev Home github extension"

This prevented previously selected repos from showing up when the repo tool was re-opened and prevented seleted items from staying selected when filtering.

The fix is to add an PluginName to CloningInformation and store "Dev Home Github Extension" into InternalProviderName and search on PluginName instead of ProviderName.

References and relevant issues

Github issue

Detailed description of the pull request / Additional comments

Validation steps performed

PR checklist

  • [ ] Closes #xxx
  • [ ] Tests added/passed
  • [ ] Documentation updated

dhoehna avatar May 22 '23 19:05 dhoehna

/azp run

dhoehna avatar May 22 '23 19:05 dhoehna

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 22 '23 19:05 azure-pipelines[bot]

/azp run

dhoehna avatar May 26 '23 16:05 dhoehna

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 26 '23 16:05 azure-pipelines[bot]

/azp run

dhoehna avatar May 26 '23 17:05 dhoehna

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar May 26 '23 17:05 azure-pipelines[bot]