devhome icon indicating copy to clipboard operation
devhome copied to clipboard

Apps to install are dropped from the UI if there is an exception in the elevated process

Open florelis opened this issue 2 years ago • 1 comments

Dev Home version

No response

Windows build number

No response

Other software

No response

Steps to reproduce the bug

Not sure how to trigger it, but what happens is:

If there is an exception in the ElevatedInstallTask() on the elevated process side, we don't catch it and convert it to a failed result, instead we just let the exception propagate. When it gets back to the main process, the handling of this call in the InstallPackageTask.ExecuteAsAdmin() does not expect an exception, but rather that any error is converted to a failed task result. Since it doesn't expect it, we just let it propagate. Then on LoadingViewModel.StartTaskAndReportResult() what we do on an exception instead of setting the task result is just ignore it. So, we just don't have any result to show it for the task after this.

Things to change:

  • Add exception handling to convert these errors to task failures
  • Figure out what's causing the exception

Expected result

No response

Actual result

No response

Included System Information

No response

Included Extensions Information

No response

florelis avatar May 22 '23 18:05 florelis

Related to #629 in that the exceptions thrown here are what we don't catch in the Loading screen

florelis avatar May 22 '23 21:05 florelis

PR: #1071

AmelBawa-msft avatar Jun 06 '23 20:06 AmelBawa-msft

Closed by #1071

florelis avatar Jun 07 '23 18:06 florelis