demikernel icon indicating copy to clipboard operation
demikernel copied to clipboard

[inetstack] Initial Sequence Number Selection is not RFC 6528 Compliant

Open BrianZill opened this issue 2 years ago • 0 comments

Context

RFC 6528 recommends using a cryptographic hash function, along with a (temporally constant) secret key, in the generation of a TCP connection's initial sequence number (ISN). Our current implementation (isn_generator.rs) doesn't appear to do either (the nonce it uses changes with each new ISN calculation, while the secret key shouldn't, see the RFC for the full explanation).

Proposed Solution

Fix our implementation to (a) use an actual cryptographic hash function, along with (b) an appropriate secret key.

BrianZill avatar Feb 03 '23 00:02 BrianZill