demikernel icon indicating copy to clipboard operation
demikernel copied to clipboard

[build] Drop Dependency on Some Third Party Packages

Open ppenna opened this issue 2 years ago • 1 comments

Context

We are using several third-party packages for performing trivial work and introducing dependencies for that reason is better to be avoided.

Proposed Solution

  • We should drop the usage of the following crates:
  • [ ] bit_iter
  • [x] #469
  • [ ] crc
  • [ ] crossbeam_channel
  • [x] #426
  • [ ] eui48
  • [x] #402
  • [x] #425
  • [x] #424

See Also

Issue #459, for a related Issue with crc.

ppenna avatar Jan 16 '23 11:01 ppenna

crc looks to only be used currently in the generation of TCP initial sequence numbers (isn_generator.rs). The recommended procedure for generating secure ISNs can be found in RFC 6528, and typically involves a cryptographic hash function, which I'm pretty sure CRC doesn't qualify as, and also a temporally constant secret key, which the nonce our current code uses isn't. I've filed Issue #459 for this.

BrianZill avatar Feb 03 '23 00:02 BrianZill