demikernel icon indicating copy to clipboard operation
demikernel copied to clipboard

[perf] Remove Task Name

Open ppenna opened this issue 11 months ago • 2 comments

Description

This PR removes tasks names from the Task structure to avoid memory allocations in the critical path.

ppenna avatar Mar 12 '24 20:03 ppenna

Looks fine to me. We put these in in the first place so we could debug more easily. Is there some way to retain that functionality without the overhead?

Sure I fixed this. Task names will be compiled for debug builds.

ppenna avatar Mar 13 '24 15:03 ppenna

Awesome, thanks for doing this.

iyzhang avatar Mar 13 '24 22:03 iyzhang

Closing this as requested by @iyzhang.

ppenna avatar Mar 18 '24 17:03 ppenna

This was replaced in PR #1191

iyzhang avatar Mar 18 '24 23:03 iyzhang