cpp_client_telemetry
cpp_client_telemetry copied to clipboard
Draft - Android - allow supply a different request factory to HttpClient
Task #1049 Enable HTTP/2.0 support for the SDK.
- Add option to provide a different request factory to HttpClient
- Add
HttpClientRequest
andHttpClientRequest.Factory
interfaces - Supply a default
AndroidUrlConnection
factory
- Add
- Add a new
maesdk-okhttp
module with okhttp implementation to avoid pulling/managing external dependencies
TODO: [ ] Test okhttp: parsing request, cancellation, http/2 connection are being reuse [ ] Add unit test for okhttp [ ] Publish okhttp module
Why don't we have okhttp implementation be the default implementation? @lalitb ?
Why don't we have okhttp implementation be the default implementation? @lalitb ?
need to cosider version management: default will require all clients to update to 4.10, and vise versa in case of new version of okhttp, the library needs to be updated...
Why don't we have okhttp implementation be the default implementation? @lalitb ?
need to cosider version management: default will require all clients to update to 4.10, and vise versa in case of new version of okhttp, the library needs to be updated...
Got it, in that case, maybe this can be the default in the next major SDK version.
@sid-dahiya Do you know if someone from office telemetry team with Android expertise (Saurabh?) can help review this code?
Why don't we have okhttp implementation be the default implementation? @lalitb ?
need to cosider version management: default will require all clients to update to 4.10, and vise versa in case of new version of okhttp, the library needs to be updated...
Got it, in that case, maybe this can be the default in the next major SDK version.
Yes, this sounds like good plan to give users option to migrate separately and test the implementation, and then make it default