component-detection icon indicating copy to clipboard operation
component-detection copied to clipboard

Add `FluentAssertions.Analyzers` and fix all warnings

Open JamieMagee opened this issue 2 years ago • 1 comments

FluentAssertions.Analyzers is a Roslyn analyzer for FluentAssertions. It's based on the FluentAssertions tips. Adding it to Component Detection, and fixing all of the warnings it gives will make sure we use best practices when writing test assertions.

In order to do this in a step-by-step way, FluentAssertions.Analyzers should be added to each test project individually, before being added to the test directory Directory.Build.props

  • [x] Microsoft.ComponentDetection.Common.Tests
    • #694
  • [x] Microsoft.ComponentDetection.Contracts.Tests
    • #634
  • [x] Microsoft.ComponentDetection.Detectors.Tests
    • #879
  • [x] Microsoft.ComponentDetection.Orchestrator.Tests
    • #634
  • [ ] Microsoft.ComponentDetection.VerificationTests

AB#2088661

JamieMagee avatar Jun 29 '23 15:06 JamieMagee

@JamieMagee could you please take a look at PR for Microsoft.ComponentDetection.Detectors.Tests - https://github.com/microsoft/component-detection/pull/879

KonH avatar Oct 26 '23 22:10 KonH