microsoft
Fix NumberPad buttons being misaligned
Fix issue #2182
PR fixes issue #2182, which has multiple unreported duplicates at the time of writing.
Description of the changes:
The NumberPad now looks at the parent grid, grabs the width of the columns, and applies it to its own columns. This eliminates the misaligned buttons in NumberPad on window resize.
How changes were validated:
The changes can be observed in the UI by looking at it. (This has been checked on all available DPI presets in the windows settings.)
- UI before the changes
- UI after the changes
Testing:
Specify how you tested your changes (i.e. manual/ad-hoc testing, automated testing, new automated tests added)-->
- The UI was tested manually.
- Provided automated UI tests were run.
- Test Results before code changes
- Test Results after code changes
Thank you, our lord and savior, for fixing the damned misalignment. I can't believe it took 218 lines of code holy hell but Microsoft should hire you man
Great work! 2 months have passed since this fix was made, can this pull request be completed already? People have been waiting for this to be fixed for years, it shouldn't have to take this long to just look at a couple hundred lines of code and approve the pull request. I don't want to have to see these crooked buttons for another day. Please, any reviewer with write access just take a look at this. Thanks a lot for taking the time to fix it, Davide!
