calculator icon indicating copy to clipboard operation
calculator copied to clipboard

Update back button style on settings page

Open 0x5bfa opened this issue 4 years ago • 7 comments

Problem Statement

Evidence or User Insights

Proposal

image

Update back button style to animated icon.

Like this image

Goals

Non-Goals

Low-Fidelity Concept

Requested Assignment

If possible, I would like to implement this.

Code

Change source code: /src/Calculator/Views/Settings.xaml

         <Button x:Name="BackButton"
                 x:Uid="TitleBarBackButton"
                 Grid.Row="0"
                 Width="44"
                 Height="{x:Bind TitleBarHeight.Value, Mode=OneWay}"
                 Margin="0,0,4,0"
                 Padding="2,0,0,0"
                 Style="{StaticResource SquareIconButtonStyle}"
                 FontSize="12"
-                Click="BackButton_Click"
-                Content="&#xE72B;"/>
+                Click="BackButton_Click">
+            <muxc:AnimatedIcon x:Name='BackAnimatedIcon'>
+                <muxc:AnimatedIcon.Source>
+                    <animatedvisuals:AnimatedBackVisualSource/>
+                </muxc:AnimatedIcon.Source>
+                <muxc:AnimatedIcon.FallbackIconSource>
+                    <muxc:SymbolIconSource Symbol='Back'/>
+                </muxc:AnimatedIcon.FallbackIconSource>
+            </muxc:AnimatedIcon>
+        </Button>

0x5bfa avatar Nov 20 '21 02:11 0x5bfa

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

MicrosoftIssueBot avatar Nov 20 '21 02:11 MicrosoftIssueBot

Hello I would like to contribute to this issue, is it still open ?

samuelmissonnier avatar Nov 23 '21 14:11 samuelmissonnier

Yes. I'm thinking of creating a PR in consideration of the reactions of other developers, but if you want to contoribute to this issue, I will close this issue👍

0x5bfa avatar Nov 23 '21 15:11 0x5bfa

thank you !

samuelmissonnier avatar Nov 26 '21 10:11 samuelmissonnier

@samuelmissonnier done??

0x5bfa avatar Dec 23 '21 13:12 0x5bfa

WHAT’S YOUR MEANS?

从 Windows 版邮件https://go.microsoft.com/fwlink/?LinkId=550986发送

发件人: @.> 发送时间: 2021年12月23日 21:52 收件人: @.> 抄送: @.***> 主题: Re: [microsoft/calculator] Update back button style on settings page (Issue #1747)

@samuelmissonnierhttps://github.com/samuelmissonnier done??

― Reply to this email directly, view it on GitHubhttps://github.com/microsoft/calculator/issues/1747#issuecomment-1000319772, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ACNERLHNI5FB6K6QLPLQ5SDUSMSTFANCNFSM5INNCM4A. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.***>

awcyy avatar Dec 23 '21 13:12 awcyy

Did you reach your goal to contribute to this issue?

0x5bfa avatar Dec 23 '21 14:12 0x5bfa