calculator icon indicating copy to clipboard operation
calculator copied to clipboard

Adapt dark mode for Graphing(MICA)

Open Shomnipotence opened this issue 3 years ago • 11 comments

The function image is an important means of expressing the function relationship. Now, it has a white background, which is out of place in the dark mode.

image

The drawing mode should be adapted to the dark mode, giving it a dark background, like this

未标题-133333

Furthermore, I think that the background of the drawing mode can be completely made of MICA, and it only needs to be slightly distinguished in terms of brightness or saturation.

Shomnipotence avatar Aug 13 '21 12:08 Shomnipotence

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

MicrosoftIssueBot avatar Aug 13 '21 13:08 MicrosoftIssueBot

You can already have dark mode friendly graph. just need a toggle. its in graph settings (adjacent to the share button) image

sabbyX avatar Aug 13 '21 18:08 sabbyX

Thanks @Shomnipotence for filing this issue! As @sabbyX mentioned above, it is by design to let users choose the graph theme either "Always light" (by default) or "Match app theme" in Graph Options. Screenshot 2021-08-18 130513

According to the official document https://docs.microsoft.com/en-us/windows/apps/design/style/mica, the Mica material is recommended to be used on the backdrop of the application — behind all other content. Another reason we don't apply Mica material to the graph is that the background painted by Mica will also render the desktop wallpaper which may cause bad visual experience and confusion to the graph.

Hope those can answer your questions.😊

hanzhang54 avatar Aug 18 '21 05:08 hanzhang54

Thanks @Shomnipotence for filing this issue! As @sabbyX mentioned above, it is by design to let users choose the graph theme either "Always light" (by default) or "Match app theme" in Graph Options. Screenshot 2021-08-18 130513

According to the official document https://docs.microsoft.com/en-us/windows/apps/design/style/mica, the Mica material is recommended to be used on the backdrop of the application — behind all other content. Another reason we don't apply Mica material to the graph is that the background painted by Mica will also render the desktop wallpaper which may cause bad visual experience and confusion to the graph.

Hope those can answer your questions.😊

First of all, thank you for your help, I already know the way to set it to dark.

But I still have to explain that mica should be used in the image area (although it can be distinguished by dividing lines or color differences on this basis), this logic is very smooth——

In the quick view in macOS, if the image is transparent in PNG, use the blurred background as the background (that is, the form itself)

Similarly, the background of the function image should also be transparent, not black or white, and it should be part of the window itself

Shomnipotence avatar Aug 18 '21 14:08 Shomnipotence

@Shomnipotence making Graph's background as same as base layer is little weird. perhaps you can suggest the Graph to use LayerFillColorDefaultBrush

The content layer should pick up the material behind it, Mica, using the LayerFillColorDefaultBrush, a low-opacity solid color, as its background.

sabbyX avatar Aug 19 '21 05:08 sabbyX

Regarding the dark mode setting. How do I set the calculator app to dark mode? I cannot find the option anywhere.

SanderBouwhuis avatar Sep 20 '21 18:09 SanderBouwhuis

The entire app theme can be set from the new settings page, available to Windows Insiders (by default, it will follow your system theme):

image

grochocki avatar Sep 20 '21 20:09 grochocki

Available to Windows Insiders? Is that only for people who work for Microsoft?

Does that mean this version isn't available here on GitHub? I thought this was an open source project.

SanderBouwhuis avatar Sep 23 '21 06:09 SanderBouwhuis

Hi @SanderBouwhuis , this is available to all Windows Insiders as of now. Everyone can join the Windows Insider Program for free, please refer to https://insider.windows.com/en-us/ for more details.

This feature code is available on GitHub, please feel free to build and try it. We haven't released the build outside of Windows Insider Program yet, and it will get released to all soon so that everyone can download the new version from Store.

hanzhang54 avatar Sep 24 '21 03:09 hanzhang54

Thanks for the info. I don't dare to join Windows Insiders because every month's standard update is already the most scary moment for my PCs. I need them for work so cannot risk it.

I guess I'll wait for the calculator to be available for everyone. Does it auto update or do I have to keep checking somewhere?

SanderBouwhuis avatar Sep 24 '21 16:09 SanderBouwhuis

@SanderBouwhuis Usually the Store will automatically update apps (You can check it in Store app settings). You can also search for "Windows Calculator" in Store to manually check the update. 😊

hanzhang54 avatar Sep 27 '21 08:09 hanzhang54