botframework-sdk icon indicating copy to clipboard operation
botframework-sdk copied to clipboard

Extension methods for Teams IP notifications

Open Jeffders opened this issue 4 years ago • 8 comments

Microsoft Teams is going to support a PII/IP scrubbing messages using messageDelete and messageUpdate activities. These will signal to the bot that it should remove or alter the message contents that it has stored for that activity. This request is to add helper methods to the Teams SDK portion of the Bot Builder SDK that can identify these operations. Specifically, it needs to be something like:

IsRetentionDeleteMessage type == messageDelete channelData contains: {"ComplianceEventType”, “RetentionDelete”}.

IsDlpBlockMessage type == messageUpdate channelData contains {"ComplianceEventType”, “DlpBlock”}.

TODO: Create repo issues for this one once it gets unblocked.

Jeffders avatar May 07 '20 21:05 Jeffders

Seems like something we could easily add. Just a couple of static methods, perhaps on TeamsInfo or at least in the C# we could consider extension methods if that was cleaner.

johnataylor avatar May 14 '20 22:05 johnataylor

@Jeffders, @clearab: do we have what we need to unblock this issue? Otherwise I will remove it from R10 and move it to the backlog.

gabog avatar Jun 23 '20 17:06 gabog

I don't think they are sending these yet - won't be until July

clearab avatar Jun 23 '20 17:06 clearab

If this gets unblocked by 7/13 then it may make it into R10, if not, we will move this one to the backlog.

gabog avatar Jun 24 '20 15:06 gabog

Moving this to the backlog, we should target this for R11

gabog avatar Jul 27 '20 21:07 gabog

@tacri Code is there, but only enabled in a feature-flag. @clearab to follow up regarding scale concerns and deployment.

cleemullins avatar Aug 03 '20 21:08 cleemullins

@tacri to let us know when to unblock and start implementation

clearab avatar Aug 10 '20 21:08 clearab

Checked with @clearab and confirmed this remains blocked. Removing from the R11 iteration.

cleemullins avatar Oct 15 '20 16:10 cleemullins