botframework-components icon indicating copy to clipboard operation
botframework-components copied to clipboard

Core Assistant: Feedback card fails to update after feedback

Open cleemullins opened this issue 3 years ago • 3 comments

Describe the bug

  1. Create / configure the basic assistant using the template.
  2. Type "Give Feedback". Click the "Thumbs Up" (which works).

Note that the card doesn't update. Click the "Thumb's down" or "Thumb's up" icons. Observe that nothing happened.

In the screen shot here, I've already clicked "Like", and gotten the "Thanks". I then try to click it again, or provide other feedback and nothing happens. image

Expected:

  • After clicking the Thumb's Up icon, the card should collapse and not be active any more.

Version

Version: 1.4.0-nightly.238698.3e4162 Electron: 8.2.4 Chrome: 80.0.3987.165 NodeJS: 12.13.0 V8: 8.0.426.27-electron.0

cleemullins avatar Apr 23 '21 21:04 cleemullins

I believe this works as design based on how PbX cards are rendered (@lauren-mills correct me if I'm mistaken). With the new Adaptive Cards package I believe we can start adding more functionality like this.

ryanisgrig avatar Apr 23 '21 21:04 ryanisgrig

After clicking the Thumb's Up icon, the card should collapse and not be active any more.

@cleemullins - this behavior is not supported by adaptive cards, and updating activities is not supported by Web Chat/emulator.

We can reevaluate this design in the next iteration to find alternatives, but for now this is as designed.

lauren-mills avatar Apr 23 '21 22:04 lauren-mills

Agree we should be able to show the "selected" option, making it very clear that another click is not possible for this specific feedback card (for other cards with Calendar/People it's nice to click on some of the previous options again (who is a peer etc)) - let's explore this in future indeed!

What we could do, if they click again insert some content "You've already provided feedback, thank you"

Quirinevwm avatar Apr 26 '21 10:04 Quirinevwm