botframework-components icon indicating copy to clipboard operation
botframework-components copied to clipboard

Greeting isn't greeting

Open clearab opened this issue 3 years ago • 2 comments

In all our generators we use the mis-labelled "Greeting" trigger to trigger our welcome/greeting dialogs. Unfortunately, this isn't actually a Greeting trigger, it fires on all ConversationUpdate Activities (which includes a lot more than membersAdded events). We need to add testing of the type of ConversationUpdate to all of these, and only do the greeting for the membersAdded type.

clearab avatar Apr 16 '21 01:04 clearab

Related: https://github.com/microsoft/BotFramework-Composer/issues/7033

clearab avatar Apr 16 '21 01:04 clearab

See also:

  • microsoft/botframework-components#939
  • microsoft/botbuilder-dotnet#5502

ryanisgrig avatar Apr 23 '21 18:04 ryanisgrig