botframework-components
botframework-components copied to clipboard
Generators: Schema files are called sdk.schema and it should be app.schema
Describe the bug
Composer is still creating the wrong file name for schema. It should not be called SDK.schema because it's the application schema.
Version
1.4.rc2
Browser
- [x] Electron distribution
- [ ] Chrome
- [ ] Safari
- [ ] Firefox
- [ ] Edge
OS
- [ ] macOS
- [x] Windows
- [ ] Ubuntu
To Reproduce
Create project, look in the schemas folder, it's sdk.schema. That is a mistake we keep propagating because nobody is taking responsibility for change the name of the damn thing. I have been filing this bug since v1.0 and we are 4 releases later and nobody has changed the name.
Expected behavior
It should be app.schema.
Screenshots
Additional context
@benbrown heads up - can you make sure this gets into the runtime templates on the new creation side?
Need to evaluate where this change will impact and ensure no unintended regression. Will pick this up in R14.
Including update-schema scripts in generators and skills.
Per @cwhitten:
Composer currently accepts both app.schema/uischema & sdk.schema/uischema, with "app" taking priority.