botframework-components icon indicating copy to clipboard operation
botframework-components copied to clipboard

Calendar Skill - Marking an event tentative throws an error to the user

Open ryub3n opened this issue 3 years ago • 4 comments

Describe the bug

Marking an event as tentative is throwing an error message

Version

Version: 2.1.2 Electron: 8.2.4 Chrome: 80.0.3987.165 NodeJS: 12.13.0 V8: 8.0.426.27-electron.0

To Reproduce

  1. Create the Enterprise Assistant with Calendar and People Skills
  2. Send "mark me as tentative for an event"
  3. It'll ask for the event title. Enter an event name that you haven't responded to (preferably one that has a large audience e.g. an event from HR)
  4. See error message

Expected behavior

It should mark me tentative or give me an appropriate reply.

Screenshots

image

It also sends this which is not an appropriate message for the user. image

ryub3n avatar May 20 '22 19:05 ryub3n

investigating

ram-xv avatar May 24 '22 19:05 ram-xv

Hello @ryub3n, Thank you for your patience. We are investigating and will get back to you once we have updates.

ram-xv avatar Jun 01 '22 23:06 ram-xv

Hi @ryub3n, thanks for reporting this issue.

I was able to reproduce using a fresh Composer Enterprise Assistant Template, It seems I received a different error message from your screenshot.

Composer v 2.1.2 Microsoft.Bot.Builder.Dialogs.Adaptive.Runtime v 4.16.0

Here are the steps I took:

  1. Run Enterprise Assistant Template from local environment
  2. Send mark me as tentative for an event
  3. The bot will ask for the event title, example send Weekly check-in with Engineers
  4. The following error is thrown

Error: UpdateEventDialog.en-us.lg:formatDateTime has invalid first argument [FormatTimeRange] Error occurred when evaluating expression. [EventDateTimeContainer] Error occurred when evaluating expression. [EventDetailBody] Error occurred when evaluating expression. [EventDetailActionsCard] Error occurred when evaluating expression. [SendActivity_F6WlGO] Error occurred when evaluating expression. [__temp__87fcc1f83c8e421bb0f2fc06d561ee38] Error occurred when evaluating expression., UpdateEventDialog.en-us.lg:formatDateTime has invalid first argument [FormatTimeRange] Error occurred when evaluating expression. [EventDateTimeContainer] Error occurred when evaluating expression. [EventDetailBody] Error occurred when evaluating expression. [EventDetailActionsCard] Error occurred when evaluating expression. [SendActivity_F6WlGO] Error occurred when evaluating expression. [__temp__5db250b4bb734794a1862486fbc1e93d] Error occurred when evaluating expression.

ram-xv avatar Jun 03 '22 02:06 ram-xv

@ramfattah, right that's the error you get if you're the meeting organizer, and if you're not you get a different error now similar to the one you sent. I don't know why it has changed but yes these errors need to be fixed.

ryub3n avatar Jun 03 '22 08:06 ryub3n

We'll be tackling this one this week.

ceciliaavila avatar Sep 19 '22 20:09 ceciliaavila

we have a PR so marking this as exempt from the daily DRI report

johnataylor avatar Oct 06 '22 20:10 johnataylor