botbuilder-python icon indicating copy to clipboard operation
botbuilder-python copied to clipboard

Add Conversation Id header in Skill Requests

Open msomanathan opened this issue 3 years ago • 1 comments

Is your feature request related to a problem? Please describe. To have better performance the bot service would like to enable the per-conversation affinity when routing the requests to the bot serivice instance. The routing gateway would not look at the payload of the request to figure out the conversation id, to have better perf, we would like to have the conversation id in HTTP header.

Describe the solution you'd like the skill related requets don't have the conversation id in the header now. It includes two scenarios

  1. Skill callback request (skill -> bot)
  2. bot as skill (parent bots -> skill)

We'd like the BF SDK could update the SDK to always include the conversation id in the header in those requests.

Describe alternatives you've considered We prefer all the channels and skills are use the same way to specifiy the conversation id in the header. Another alternative is to extract conversation id from the request URL, it will add the complexity to the gateway or parse the URL and there is no standard on how to extract conversation id from URL. And it may not work for the scenario of bot as skill.

msomanathan avatar Jun 25 '21 01:06 msomanathan

See https://github.com/microsoft/botbuilder-dotnet/pull/5741

tracyboehrer avatar Jun 28 '21 17:06 tracyboehrer

Changes added partially through other fixes, need to port missing changes.

gandiddi avatar Jul 15 '24 10:07 gandiddi