botbuilder-js icon indicating copy to clipboard operation
botbuilder-js copied to clipboard

Inconsistent ConversationParameters interface

Open Wadu436 opened this issue 11 months ago • 2 comments

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Versions

  • What package version of the SDK are you using.
    [email protected]

  • What nodejs version are you using N/A but Node 22

  • What browser version are you using N/A but Chrome

  • What os are you using N/A but MacOS 15.3

Describe the bug

There's an inconsistency between the docstring and the actual type for the activity field in the ConversationParameters interface. The docstring claims it is optional, but according to the type it is required.

To Reproduce

Steps to reproduce the behavior:

  1. Go to index.ts:872-876 file in the botframework-schema
  2. Look at the docstring for the activity field
  3. Look at the type for the activity field

Expected behavior

For the docstring and the interface to be consistent.

Wadu436 avatar Feb 13 '25 14:02 Wadu436

@Wadu436 - Thank you for bringing this to our attention. We will look this over and address it in a future release.

stevkan avatar Mar 05 '25 01:03 stevkan

Hi, is there any update on when this issue will be addressed?

Wadu436 avatar Jun 02 '25 10:06 Wadu436

Confirmed fixed in 4.23.3 🙏

ndom91 avatar Sep 02 '25 09:09 ndom91