botbuilder-js icon indicating copy to clipboard operation
botbuilder-js copied to clipboard

refactor: Add Recognizers-Text packages to botbuilder-stdlib

Open sw-joelmut opened this issue 9 months ago • 1 comments

#minor

Related PR: https://github.com/microsoft/botbuilder-js/pull/4661

Description

This PR adds https://github.com/microsoft/Recognizers-Text into botbuilder-stdlib library, so it's easier to update vulnerable dependencies without introducing breaking changes. botbuilder-stdlib is an internal library that contains helper functions which the rest of botbuilder libraries use. Therefore, we included the Recognizers-Text packages under the vendors folder, so botbuilder libraries can consume them.

Specific Changes

  • Updated libraries/botbuilder-repo-utils/src/workspace.ts to search workspaces, taking into account .gitignore and the location where the command is run. Otherwise, it will cause unwanted behaviors where nested dependencies inside node_modules were considered as a workspace.
  • Added all Recognizers-Text packages into the vendors folder.
    • All dependencies have been moved to botbuilder-stdlib package.json, so they are installed properly.
    • Updated all types references to match each Recognizers-Text package inside botbuilder-stdlib.

Testing

The following image shows the bot working with the new Recognizers-Text packages inside BotBuilder. imagen

sw-joelmut avatar May 07 '24 12:05 sw-joelmut