botbuilder-js icon indicating copy to clipboard operation
botbuilder-js copied to clipboard

[node] Crash on websocket errors

Open orgads opened this issue 2 years ago • 3 comments

Versions

What package version of the SDK are you using. 4.19.1-rc What nodejs version are you using 18.14.0 What os are you using Windows

Describe the bug

Give a clear and concise description of what the bug is. With the recent fixes to the streaming framework, I can start the connection, but if I get an error, an unhandled exception is thrown from here, and I can't find a way to handle it. Looks similar to https://github.com/microsoft/BotFramework-DirectLineJS/issues/170.

To Reproduce

Connect to a URL that doesn't respond.

Expected behavior

It should propagate the error to be handled by the client code.

orgads avatar Feb 12 '23 08:02 orgads

Reported originally here: https://github.com/microsoft/botbuilder-js/issues/4412#issuecomment-1406167695

orgads avatar Feb 12 '23 08:02 orgads

@compulim do we have any updates on this?

axelsrz avatar Feb 14 '23 19:02 axelsrz

@compulim Is this still a thing?

tracyboehrer avatar Jan 26 '24 19:01 tracyboehrer