botbuilder-js icon indicating copy to clipboard operation
botbuilder-js copied to clipboard

deleteConversationMember is returning 405 error

Open krosenk729 opened this issue 2 years ago • 12 comments

Github issues should be used for bugs and feature requests. Use Stack Overflow for general "how-to" questions.

Versions

What package version of the SDK are you using: 4.14.1 What nodejs version are you using: 14.20 What os are you using: macos

Describe the bug

when calling deleteConversationMember, a 405 error is returned The requested resource does not support http method 'DELETE' ... the endpoint should exist per MS documentation https://docs.microsoft.com/en-us/azure/bot-service/rest-api/bot-framework-rest-connector-api-reference?view=azure-bot-service-4.0#delete-conversation-member which is the same path 'v3/conversations/{conversationId}/members/{memberId}' returned in the error request.operationSpec

To Reproduce

Steps to reproduce the behavior:

  1. Setup teams SDK to create a new BotFrameworkAdapter instance and call botFrameworkAdapter.deleteConversationMember(context, memberId) in response to an event

Expected behavior

Expect member to be removed from conversation without an error response

Screenshots

image

Additional context

Add any other context about the problem here.

krosenk729 avatar Aug 24 '22 18:08 krosenk729

Thank you @krosenk729.

I am investigating. Out of curiosity have you tested this in any other language? Curious to know if it works/fails in C#/dotnet.

dmvtech avatar Aug 29 '22 17:08 dmvtech

@dmvtech I have only tried with node/js

krosenk729 avatar Aug 29 '22 18:08 krosenk729

Thank you @krosenk729. I am continuing to investigate and hope to have some information soon. Thank you for your patience.

dmvtech avatar Sep 07 '22 17:09 dmvtech

thanks for the update @dmvtech I appreciate you keeping me in the loop

krosenk729 avatar Sep 07 '22 17:09 krosenk729

hey @dmvtech just checking in again... my team is blocked on some feature work/decisions based on the fix for this. how is it going?

krosenk729 avatar Sep 19 '22 12:09 krosenk729

Hi @krosenk729

Apologies for the delay. We are still investigating and hope to have some updates for you soon.

dmvtech avatar Sep 20 '22 17:09 dmvtech

@JuanAr I was able to confirm this behavior. Assigning to you for resolution.

dmvtech avatar Sep 22 '22 00:09 dmvtech

Hi everyone, We reproduced the issue with a Teams bot, and we think the error is due to the Teams channel not supporting this operation. The request is correctly sent to the Connector service and it returns the 405 error code. As the documentation states, not all channels support all endpoints. We also found some similar issues: https://stackoverflow.com/questions/73331696/how-can-skype-bot-delete-conversation-member https://github.com/MicrosoftDocs/bot-docs/issues/1357#issuecomment-949976150

ceciliaavila avatar Sep 29 '22 19:09 ceciliaavila

@ceciliaavila is it a channel-specific issue? so some channels will not give a 405 error but some channels will?

krosenk729 avatar Sep 29 '22 19:09 krosenk729

@krosenk729 that's correct. A method may be supported by some channels and not by others.

ceciliaavila avatar Sep 29 '22 19:09 ceciliaavila

@ceciliaavila how do we update channels to support this method?

krosenk729 avatar Sep 29 '22 20:09 krosenk729

Hi @krosenk729, just to clarify, by channel I mean the MSTeams channel. This is a feature that is not enabled for bots in MSTeams.

ceciliaavila avatar Sep 30 '22 11:09 ceciliaavila

Closing this due to inactivity

axelsrz avatar Oct 11 '22 18:10 axelsrz