botbuilder-js
botbuilder-js copied to clipboard
port: Do not check for streaming activity if ServiceUrl is null. (#6282)
The changes in Do not check for streaming activity if ServiceUrl is null. (#6282) may need to be ported to maintain parity with microsoft/botbuilder-dotnet
.
Fixes #6281Description
When checking for an active web socket connection to send a proactive message, the ServiceUrl on the connection is compared to the ServiceUrl on the activity. This check is failing when the ServiceUrl is null. This PR will ignore the connection that has no ServiceUrl.
Please review and, if necessary, port the changes.
Hi @tracyboehrer, we've been reviewing this port issue and doesn't apply to JS, due to lacking the necessary changes from another porting issue (port: Streaming Library Refactor - #3955) that was marked as "Not needed in JS.".
Thanks.
Closing as the port is not needed.