botbuilder-js icon indicating copy to clipboard operation
botbuilder-js copied to clipboard

port: Do not check for streaming activity if ServiceUrl is null. (#6282)

Open github-actions[bot] opened this issue 2 years ago • 1 comments

The changes in Do not check for streaming activity if ServiceUrl is null. (#6282) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #6281

Description

When checking for an active web socket connection to send a proactive message, the ServiceUrl on the connection is compared to the ServiceUrl on the activity. This check is failing when the ServiceUrl is null. This PR will ignore the connection that has no ServiceUrl.

Please review and, if necessary, port the changes.

github-actions[bot] avatar Mar 31 '22 20:03 github-actions[bot]

Hi @tracyboehrer, we've been reviewing this port issue and doesn't apply to JS, due to lacking the necessary changes from another porting issue (port: Streaming Library Refactor - #3955) that was marked as "Not needed in JS.".

Thanks.

sw-joelmut avatar Apr 27 '22 13:04 sw-joelmut

Closing as the port is not needed.

ceciliaavila avatar Jan 16 '23 13:01 ceciliaavila