botbuilder-java
botbuilder-java copied to clipboard
[CloudAdapter] Port CloudAdapter to Java
Fixes #1222 Fixes #1266
Description
As the CloudAdapter component was migrated to C#, it should be added in Java with all supporting classes and make the necessary changes in the existing code to support the CloudAdapter component.
Specific Changes
- Add CloudAdapter component and all supporting classes
- Add CloudAdapter Tests
- Add
mockito
inbot-integration-core
- Add
CloudAdapterWithErrorHandler
which inherits from CloudAdapter used by some Java samples - Add
getCloudAdapter
inBotDependencyConfiguration
to return aCloudAdapterWithErrorHandler
- Add
InvokeResponse
andTypedInvokeResponse
to bot-schema, assign old ones as deprecated - Relocate
BotFrameworkClient
to bot-connector to have parity with JS - Fix Checkstyle issues
Testing
mvn clean install passing correctly
We added additional commits with the stabilization work done on the implementation of CloudAdapter
Specific changes
- Added a REST Controller for
CloudAdapter
- Added
CloudAdapterWithInspection
- Fixed return types for
CompleatableFuture
causing aNullPointerException
- Fixed string comparisons
- Fixed incorrect recursive call
- Implemented
UserTokenAccess
static class to grantCloudAdapter
access to an instance ofUserTokenProvider
- Added unit tests for
UserTokenAccess
- Added test cases for
ParameterizedBotFrameworkAuthentication
Please let us know if you have any question
Any updates? It's been almost a year and I wonder what's keeping it from merging?
@ldardick Hi Dick, I was wondering if you could help me understand: 1. What problem does CloudAdapter try to solve instead of BotFrameworkAdapter? 2. Why hasn't this PR been reviewed and merged after over a year? Appreciate it!