botbuilder-java icon indicating copy to clipboard operation
botbuilder-java copied to clipboard

[CloudAdapter] Port CloudAdapter to Java

Open ldardick opened this issue 3 years ago • 4 comments

Fixes #1222 Fixes #1266

Description

As the CloudAdapter component was migrated to C#, it should be added in Java with all supporting classes and make the necessary changes in the existing code to support the CloudAdapter component.

Specific Changes

  • Add CloudAdapter component and all supporting classes
  • Add CloudAdapter Tests
  • Add mockito in bot-integration-core
  • Add CloudAdapterWithErrorHandler which inherits from CloudAdapter used by some Java samples
  • Add getCloudAdapter in BotDependencyConfiguration to return a CloudAdapterWithErrorHandler
  • Add InvokeResponse and TypedInvokeResponse to bot-schema, assign old ones as deprecated
  • Relocate BotFrameworkClient to bot-connector to have parity with JS
  • Fix Checkstyle issues

Testing

mvn clean install passing correctly image

ldardick avatar Jul 14 '21 20:07 ldardick

CLA assistant check
All CLA requirements met.

ghost avatar Jul 14 '21 20:07 ghost

We added additional commits with the stabilization work done on the implementation of CloudAdapter

Specific changes

  • Added a REST Controller for CloudAdapter
  • Added CloudAdapterWithInspection
  • Fixed return types for CompleatableFuture causing a NullPointerException
  • Fixed string comparisons
  • Fixed incorrect recursive call
  • Implemented UserTokenAccess static class to grant CloudAdapter access to an instance of UserTokenProvider
  • Added unit tests for UserTokenAccess
  • Added test cases for ParameterizedBotFrameworkAuthentication

Please let us know if you have any question

ldardick avatar Aug 20 '21 14:08 ldardick

Any updates? It's been almost a year and I wonder what's keeping it from merging?

johnmiroki avatar Jun 13 '22 01:06 johnmiroki

@ldardick Hi Dick, I was wondering if you could help me understand: 1. What problem does CloudAdapter try to solve instead of BotFrameworkAdapter? 2. Why hasn't this PR been reviewed and merged after over a year? Appreciate it!

johnmiroki avatar Aug 06 '22 11:08 johnmiroki