botbuilder-dotnet
botbuilder-dotnet copied to clipboard
microsoft
Microsoft.Identity.Client bump
Pull Request Test Coverage Report for Build 388608
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 74 unchanged lines in 7 files lost coverage.
- Overall coverage decreased (-0.005%) to 78.16%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| /libraries/Microsoft.Bot.Connector/Authentication/ManagedIdentityAuthenticator.cs | 1 | 91.89% |
| /libraries/Microsoft.Bot.Builder/TokenResolver.cs | 4 | 95.69% |
| /libraries/AdaptiveExpressions/LRUCache.cs | 4 | 87.18% |
| /libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Templates/ActivityTemplate.cs | 5 | 72.22% |
| /libraries/Microsoft.Bot.Builder/TranscriptLoggerMiddleware.cs | 5 | 92.0% |
| /libraries/Microsoft.Bot.Builder/FileTranscriptLogger.cs | 7 | 94.24% |
| /libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/AdaptiveDialog.cs | 48 | 88.79% |
| <!-- | Total: | 74 |
| Totals | |
|---|---|
| Change from base Build 388195: | -0.005% |
| Covered Lines: | 26185 |
| Relevant Lines: | 33502 |
💛 - Coveralls
:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll :heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll :heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Connector.dll
@sw-joelmut Most of the changes can be ignored. The newer package introduced some ambiguity because "Activity" was defined.
The real change is in ManagedIdentityAuthenticator.cs and corresponding tests. It would appear that the new Managed Identity client automatically retries for exceptions, and everything is now an exception. I didn't see a way to disable their retry. So effectively, this could would be trying max 20 times.