botbuilder-dotnet icon indicating copy to clipboard operation
botbuilder-dotnet copied to clipboard

Adaptive ForEachElement does not exit when child action CancelAllDialogs is called

Open Rich-biomni opened this issue 3 years ago • 9 comments

Version 4.16.1

Describe the bug

When a ForEachElement Child Action is CancelAllDialogs the ForEachElement Loops again rather than cancelling This is also the case when there are nested ForEachElement actions aand at the lowest point a CancelAllDialogs is ran

To Reproduce

Create and adaptive dalog Create a ForEachElement In the action add a message, question, CancelAllDialogs, message Run the dialog

-- Create and adaptive dalog Create a ForEachElement with a sub foreachElement In the action add a message, question, CancelAllDialogs, message Run the dialog

Expected behavior

All foreachElement should cancel but instead it loops

Additional context

Add Zip with repoduction

SimpleBot.zip

Rich-biomni avatar Aug 04 '22 13:08 Rich-biomni

Related to #6428

stevkan avatar Aug 04 '22 17:08 stevkan

Adding the sample bot again, since on a different bug it was mentioned, the sample could not be run / reproduced because of an out dated dependenc SimpleBot.zip

Rich-biomni avatar Aug 05 '22 07:08 Rich-biomni

@Rich-biomni - I was able to repro the issue using your sample. Unfortunately, I was unable to find a simple solution / workaround to help mitigate this for you.

Escalating to @ceciliaavila for continued support on this.

stevkan avatar Aug 09 '22 18:08 stevkan

Is this repeatable in 4.17.1?

tracyboehrer avatar Aug 10 '22 14:08 tracyboehrer

@tracyboehrer

Issue exists in 4.17.1 as well

Rich-biomni avatar Aug 15 '22 13:08 Rich-biomni

This PR for this was reverted due to a breaking change. We will need to revisit.

Notes for SDK: This breaks Bot Designers (PVA) "SlotFillingTest" and some "IntentSwitchingTests". We will need to extract the tests to reproduce outside PVA.

tracyboehrer avatar Sep 08 '22 15:09 tracyboehrer

We need information on the broken PVA tests to reproduce on the SDK side.

ceciliaavila avatar Sep 19 '22 20:09 ceciliaavila

we have a PR so marking this as exempt from the daily DRI report

johnataylor avatar Oct 06 '22 20:10 johnataylor

Actually... this is still outstanding. See the note above about the PR being reverted until we can duplicate outside of PVA scenario tests in SDK. Still fine to exempt for now though.

tracyboehrer avatar Oct 06 '22 20:10 tracyboehrer