botbuilder-dotnet icon indicating copy to clipboard operation
botbuilder-dotnet copied to clipboard

Created XML tags using System.Xml

Open ram-xv opened this issue 3 years ago • 4 comments

Fixes #5792

Description

Ensure the appropriate SSML tags are set on the Activity Speak property using System.Xml.Linq classes such as XDocument & XElement.

Testing

Voice is added to Speak property

AddVoice

Input:

Output:

image

Custom voice tag

AddVoice_NullSpeak

Voice is added with no speak tag

Input:

Output:

image

Multiple voice tags

AddMultiVoice

Input:

Output:

image

Custom speak is added with voice tag

AddSpeakWithVoice

Input:

Output:

image

Custom speak is added with no voice tag

AddSpeak_NullVoice

Input:

Output:

image

All SetSpeakMiddlewareTest

SetSpeakMiddlewareTests.cs

ram-xv avatar Apr 28 '22 21:04 ram-xv

CLA assistant check
All CLA requirements met.

ghost avatar Apr 28 '22 21:04 ghost

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll

BruceHaley avatar Jul 05 '22 18:07 BruceHaley

:heavy_check_mark: No Binary Compatibility issues for Microsoft.Bot.Builder.dll

BruceHaley avatar Sep 23 '22 18:09 BruceHaley