botbuilder-dotnet
botbuilder-dotnet copied to clipboard
[MCS-DE] Max turn count ignored when adding validation rule
When I add a validation rule to a "Prompt for text" action in Composer v2.0.0 and in addition turn "Allow interruptions = true", the max turn count setting is ignored and the question is repeating indefinitely. When I turn "Allow interruptions = false", the max turn count setting is used.
Update; This seems to happen only on a Bot newly created in v2.0.0. In my migrated Bot, the dialog works correctly. It seems the v2.0.0 changed runtime is producing this differently than the older Bot runtime in my migrated bot.
Adding a note: When I switch the Microsoft.Bot.Builder.* packages from "4.14.1" to "4.13.1" in my local Bot csproj, the bug does not occur.
@goergenj Is this the Microsoft.Bot.Builder.dotnet dependency or JS?
@srinaath .Net Microsoft.Bot.Builder.AI.Luis Microsoft.Bot.Builder.AI.QnA Microsoft.Bot.Builder.Dialogs.Adaptive.Runtime
@mrivera-ms could you take a look at this ticket? The issue does not seem to surface on an older version.
@srinaath @mrivera-ms Any update on this topic? Will this be fixed in the next release? We currently cannot upgrade from 2.0.0 to 2.1.0 due to this issue.
There is a fix https://github.com/microsoft/botbuilder-dotnet/pull/5690 done in Microsoft.Bot.Builder v 14.4.0 (Issue: https://github.com/microsoft/botbuilder-dotnet/issues/5611) to not increase max turn count when Allow Interruptions is set to true. So this seems like expected behavior.
@skommireddi Thanks for reaching out via Chat. This must be discussed. If this is the new expected behaviour this is a major change and a major issue to a number of Bots and projects.