botbuilder-dotnet icon indicating copy to clipboard operation
botbuilder-dotnet copied to clipboard

[MCS-DE-GO] Skillconnection breaks with 1.4.0. Bot Runtime

Open goergenj opened this issue 3 years ago • 7 comments

After the upgrade to Composer 1.4.0 we noticed that after a Skill has completed it's dialog, the root-Bot does not continue the Conversation.

It seems in the new version of the runtime does not correctly send the "ContinueConversation" flag with the "EndOfConversation".

Reverting to the previous version of the runtime on the root-Bot solved the issue so we assume this is a bug in the "/api/skills" receiving the "replyto" message.

Critical issue for our customer as our productive version is impacted!

@joaollq @goergenj @garypretty @benbrown @cwhitten.

goergenj avatar Apr 27 '21 16:04 goergenj

Needs triage and and ShipRoom approval before addressing.

cwhitten avatar Apr 27 '21 17:04 cwhitten

@gabog - can you comment here? Seems similar to the skill reprompting issue we resolved earlier.

lauren-mills avatar Apr 27 '21 18:04 lauren-mills

@gabog can you work this for a patch release in the SDK? thanks.

sgellock avatar Apr 28 '21 15:04 sgellock

Shiproom - removing approval as we don't have a repro and a root cause yet.

sgellock avatar Apr 29 '21 22:04 sgellock

We found the causes for the double input as discussed with Gabo. We fixed a code issue in our Custom SharedSkill Issue which caused the double inputs required. All Skill-Calls must be changed to use the Custom Action.

The 500 error was relaated to the Skill sending Events which interrupted the root Bot. We were able to fix this by adding an "Event Catcher" in our root-Bot which solved this issue.

Any Bot that calls a Skill which emits events, e.g. Audiocodes Config Events, must have a trigger which catches these Events and add an EndTurn to them.

This should be properly documented for others running into this issue with Skills or a permanent implementation in the Skill API-Endpoint on the root Bot should be added.

goergenj avatar Apr 30 '21 15:04 goergenj

Shiproom - moving out of R13. @Kaiqb please note the request for documentation. @gabog can you work with Kamran on the doc request? thanks

sgellock avatar Apr 30 '21 15:04 sgellock

@sgellock Has the documentation been extended with a best practice which catches all cases like this by now?

goergenj avatar Aug 26 '21 08:08 goergenj