bedrock icon indicating copy to clipboard operation
bedrock copied to clipboard

Generated pipelines should perform lookup based on pipeline id for first build instead of image tag

Open samiyaakhtar opened this issue 4 years ago • 0 comments

As a: developer

I want: to optimize the generated pipelines for multi-stage instead of single stage pipelines

So that: spk deployment create logic is simplified to perform lookup based on p1 rather than imageTag. Previously, it was done this way to handle both single stage and multi stage pipelines but for generated pipelines, it's more straightforward to rely on p1.

Describe the solution you'd like:

  • [ ] Modify spk deployment create to accept p1 (pipeline id for SRC to ACR) as an argument when adding details for ACR to HLD pipeline, and perform lookup based on p1 as well as imageTag (depending on whatever is passed in), since p1 = p2 in multi-stage pipelines
  • [ ] Once this change above is available in a release, consume the changes in generated pipelines

Note that this would be backwards compatible since we don't remove lookup logic for imageTag, which will still support single stage pipelines.

Acceptance Criteria: spk deployment create lookup logic is simplified for multi-stage pipelines

Describe alternatives you've considered: Keep it as it is

Additional context:

Does this require updates to documentation?: Yes

samiyaakhtar avatar Apr 20 '20 19:04 samiyaakhtar