beachball icon indicating copy to clipboard operation
beachball copied to clipboard

Feature: Beachball change should work with packages marked private

Open JamesBurnside opened this issue 3 years ago • 1 comments

Currently having private: true or beachball: { shouldPublish: false } in the package.json will mean that package is ignored by the beachball change command. However it would be great to be able to still get the benefit of using beachball for changelogs for "private" packages (i.e. packages you want to ensure will never be published to npm).

One solution would be to add an option to the configuration, e.g.:

Option Type Alias Default Option Type Description
processPrivate boolean   false repo, package Process packages marked private in the package.json.

This could then be added as a condition to getChangedPackages: https://github.com/microsoft/beachball/blob/7c18046e90a8c1dfb7c28722d0a3812108fc9009/src/changefile/getChangedPackages.ts#L30

Alternatively a different option would be to allow beachball change to still work on a private package if shouldPublish is false as this is not a publishing step but that would be a breaking change.

JamesBurnside avatar Feb 27 '21 21:02 JamesBurnside

Is there a green light on this change? Looks like the PR got hung up in a CI failure, but the log expired so idk what the failure was.

matthias-ccri avatar Jan 31 '22 18:01 matthias-ccri