azurelinux icon indicating copy to clipboard operation
azurelinux copied to clipboard

Updated context to be used for HTTP request + refactoring

Open PawelWMS opened this issue 1 year ago • 0 comments

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • [X] The toolchain has been rebuilt successfully (or no changes were made to it)
  • [X] The toolchain/worker package manifests are up-to-date
  • [X] Any updated packages successfully build (or no packages were changed)
  • [X] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • [X] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • [X] All package sources are available
  • [X] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • [X] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • [X] All source files have up-to-date hashes in the *.signatures.json files
  • [X] sudo make go-tidy-all and sudo make go-test-coverage pass
  • [X] Documentation has been updated to match any changes to the build system
  • [X] Ready to merge

Summary
  • Expanded the use of context to pass it to our HTTP requests.
  • Added a context nil check in azureblobstorage.go.
  • Re-named cancelCtx to closeCtx to better reflect the purpose of some of our defer calls.
  • 1 loop refactoring to use the for element := range someChannel loops.
Does this affect the toolchain?

No.

Associated issues
  • #9251
Test Methodology

PawelWMS avatar Jun 04 '24 00:06 PawelWMS