azurelinux
azurelinux copied to clipboard
fix: add repoutils.FindCreateRepoCommand to flexibly use either creat…
…erepo or createrepo_c
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
- [x] The toolchain has been rebuilt successfully (or no changes were made to it)
- [x] The toolchain/worker package manifests are up-to-date
- [x] Any updated packages successfully build (or no packages were changed)
- [x] Packages depending on static components modified in this PR (Golang,
*-staticsubpackages, etc.) have had theirReleasetag incremented. - [x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
- [x] All package sources are available
- [x] cgmanifest files are up-to-date and sorted (
./cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json) - [x] LICENSE-MAP files are up-to-date (
./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON) - [x] All source files have up-to-date hashes in the
*.signatures.jsonfiles - [x]
sudo make go-tidy-allandsudo make go-test-coveragepass - [x] Documentation has been updated to match any changes to the build system
- [x] Ready to merge
Summary
Improves our retrieval of the createrepo command used by the rpmrepomanager.
Previously, running image customizer on an Ubuntu devbox resulted in a executable file not found in $PATH error even with createrepo-c (Debian's createrepo package) installed.
Screenshot below shows:
- repro of the error
- building the tool with this fix
- a successful run with the tool now fixed
Change Log
Does this affect the toolchain?
NO
Associated issues
Links to CVEs
Test Methodology
- local
Should be targeting the 3.0-dev branch.