azurelinux icon indicating copy to clipboard operation
azurelinux copied to clipboard

Add "cbl-mariner-multi-package-reviewers" when a multi-package .spec file is added or removed

Open kimoantiqe opened this issue 1 year ago • 0 comments

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • [NA] The toolchain has been rebuilt successfully (or no changes were made to it)
  • [NA] The toolchain/worker package manifests are up-to-date
  • [NA ] Any updated packages successfully build (or no packages were changed)
  • [NA] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • [NA] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • [NA] All package sources are available
  • [NA] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • [NA] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • [NA] All source files have up-to-date hashes in the *.signatures.json files
  • [NA] sudo make go-tidy-all and sudo make go-test-coverage pass
  • [NA] Documentation has been updated to match any changes to the build system
  • [ ] Ready to merge

Summary

When adding a multi-package, our internal CVE detection pipelines need a manual change. For the near future, cbl-mariner-multi-package-reviewers members are responsible for ensuring a smooth onboarding/off-boarding of multi-packages.

Change Log
  • A reminder for devs in the PR template to add cbl-mariner-multi-package-reviewers as reviewers
  • A github workflow that force adds cbl-mariner-multi-package-reviewers as reviewers when it detects the addition/removal of .spec files causing a multi-pack situation,
Test Methodology

The following scenarios were tested, covering all the use cases

kimoantiqe avatar Apr 08 '24 22:04 kimoantiqe