azurelinux icon indicating copy to clipboard operation
azurelinux copied to clipboard

Sammeluch/fasttrack/sodiff debuginfo fix

Open sameluch opened this issue 2 years ago • 0 comments

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • [x] The toolchain has been rebuilt successfully (or no changes were made to it)
  • [x] The toolchain/worker package manifests are up-to-date
  • [x] Any updated packages successfully build (or no packages were changed)
  • [x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • [x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • [x] All package sources are available
  • [x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • [x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • [x] All source files have up-to-date hashes in the *.signatures.json files
  • [x] sudo make go-tidy-all and sudo make go-test-coverage pass
  • [x] Documentation has been updated to match any changes to the build system
  • [x] Ready to merge

Summary

What does the PR accomplish, why was it needed? sodiff was not functioning as expected for 2.0 given the split of debuginfo repos from the base packages when compared to its implementation for 1.0. Added repositories for debug info for both core and extended repo generation commands. Additionally added the functionality for use with extended and a modular choice on whether the script produces an error.

Change Log
  • Add debuginfo repo to sodiff checks
  • Add commands for use with extended repo
  • fix error when no rpms are built
  • Add error variable for when we want the script to cause an error
  • Add parameter validation
Does this affect the toolchain?

NO

Test Methodology
  • Local testing
  • Pipeline build id: Extended Build with Run: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=449079&view=results
  • build RPMS: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=447198&view=results
  • Fast Track: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=445738&view=results (Failed result, but good sodiff for core and extended of ARM64)

sameluch avatar Nov 08 '23 21:11 sameluch