azurelinux
azurelinux copied to clipboard
Add perl-Authen-SASL and perl-IO-Socket-SSL as requires to git package
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
- [ ] The toolchain has been rebuilt successfully (or no changes were made to it)
- [ ] The toolchain/worker package manifests are up-to-date
- [ ] Any updated packages successfully build (or no packages were changed)
- [ ] Packages depending on static components modified in this PR (Golang,
*-staticsubpackages, etc.) have had theirReleasetag incremented. - [ ] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
- [ ] All package sources are available
- [ ] cgmanifest files are up-to-date and sorted (
./cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json) - [ ] LICENSE-MAP files are up-to-date (
./SPECS/LICENSES-AND-NOTICES/data/licenses.json,./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md,./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON) - [ ] All source files have up-to-date hashes in the
*.signatures.jsonfiles - [ ]
sudo make go-tidy-allandsudo make go-test-coveragepass - [ ] Documentation has been updated to match any changes to the build system
- [ ] Ready to merge
Summary
What does the PR accomplish, why was it needed?
- https://microsoft.visualstudio.com/OS/_sprints/taskboard/Mariner%20Platform/OS/2211?workitem=41520384
- Git send-mail fails due to missing perl dependencies (Perl-IO-Socket-SSL and Perl-Authen-SSL)
- This PR adds these missing dependencies to git.spec
Change Log
- Added
Requires: perl-Authen-SASLandRequires: perl-IO-Socket-SSLto git.spec - Moved perl-Authen-SASL from SPECS-EXTENDED to SPECS
- Moved perl-GSSAPI from SPECS-EXTENDED to SPECS as perl-Authen-SASL depends on it (BuildRequires)
Does this affect the toolchain?
NO
Associated issues
- #xxxx
Links to CVEs
- https://nvd.nist.gov/vuln/detail/CVE-YYYY-XXXX
Test Methodology
- Buddy build (AMD64): https://dev.azure.com/mariner-org/mariner/_build/results?buildId=260412&view=results
- Buddy build (ARM64): https://dev.azure.com/mariner-org/mariner/_build/results?buildId=260439&view=results
In order to test this, I did the following:
docker run -it mcr.microsoft.com/cbl-mariner/base/core:2.0 /bin/bashmkdir testingcd testing- I copied over three 3 RPMS into the container:
git-2.33.4-2.cm2.x86_64.rpm,perl-GSSAPI-0.28-32.cm2.x86_64.rpmandperl-Authen-SASL-2.16-22.cm2.noarch.rpm rpm -ivh perl-GSSAPI-0.28-32.cm2.x86_64.rpmtdnf install -y perl-Authen-SASL-2.16-22.cm2.noarch.rpmtdnf install -y git-2.33.4-2.cm2.x86_64.rpmgit initecho "test" > test.txtgit add test.txtgit commit -m "first commit"- At this point, you should be prompted to fill out your name and email address (for git)
- I edited my gitconfig to look like this:

- This stack overflow link explains how to set up the gitconfig file
- A few important things to note:
- https://support.google.com/accounts/answer/6010255?hl=en (you have to create an app password to use and put this in your gitconfig file)
- In order to authenticate with smtp.gmail.com, I got the cert from here with the hostname as
smtp.gmail.com