azurelinux icon indicating copy to clipboard operation
azurelinux copied to clipboard
verified publisher icon microsoft

Move nbdkit and its dependent packages from Extended to Core

Open ausgaonkar opened this issue 3 years ago • 3 comments

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • [x] The toolchain has been rebuilt successfully (or no changes were made to it)
  • [x] The toolchain/worker package manifests are up-to-date
  • [x] Any updated packages successfully build (or no packages were changed)
  • [x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • [x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • [x] All package sources are available
  • [x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • [x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • [x] All source files have up-to-date hashes in the *.signatures.json files
  • [x] sudo make go-tidy-all and sudo make go-test-coverage pass
  • [x] Documentation has been updated to match any changes to the build system
  • [x] Ready to merge
Summary

PR to move nbdkit and its dependent packages from extended to core. This package is one of the dependencies for CDI package.

Change Log

Nbdkit is dependent on the following packages which have also been moved from extended to core:

  • Podman
  • Containernetworking-plugins
  • go-rpm-macros
  • catatonit
  • slirp4netns
  • buildah

Successful buddy build pipeline can be found here.

Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
  • https://nvd.nist.gov/vuln/detail/CVE-YYYY-XXXX
Test Methodology

ausgaonkar avatar Nov 02 '22 09:11 ausgaonkar

The go-rpm-macros.spec is the only file that has %forgemeta macro. I could not locate any SPEC file that has %forgemeta macro. Hence, I am unable to resolve the spec-lint error. This link tells something about lua and how to handle. Can someone help on how to go about this?

ausgaonkar avatar Nov 02 '22 11:11 ausgaonkar

The go-rpm-macros.spec is the only file that has %forgemeta macro. I could not locate any SPEC file that has %forgemeta macro. Hence, I am unable to resolve the spec-lint error. This link tells something about lua and how to handle. Can someone help on how to go about this?

@ameyapu, I've taken a look at this check and the problem is with running the check in Ubuntu, where it doesn't have Mariner's lua modules installed by mariner-rpm-macros. I'm working on a fix for the PR check to get you (and all future devs working with forgemeta macros unblocked. Sorry for the trouble!

PawelWMS avatar Nov 03 '22 20:11 PawelWMS

The go-rpm-macros.spec is the only file that has %forgemeta macro. I could not locate any SPEC file that has %forgemeta macro. Hence, I am unable to resolve the spec-lint error. This link tells something about lua and how to handle. Can someone help on how to go about this?

@ameyapu Ameya Usgaonkar FTE, I've taken a look at this check and the problem is with running the check in Ubuntu, where it doesn't have Mariner's lua modules installed by mariner-rpm-macros. I'm working on a fix for the PR check to get you (and all future devs working with forgemeta macros unblocked. Sorry for the trouble!

I've pushed the fix to main. You might need to merge the latest main or rebase your changes on top of it to have the new check kick in. It maybe be also possible that just another commit to this PR will help - I am not entirely clear on how these PR checks run.

PawelWMS avatar Nov 04 '22 19:11 PawelWMS

A few clean-up request. Please also make sure that:

  1. We remove all duplicate spec folder from SPECS-EXTENDED.
  2. The moved packages build fine in the buddy build for both architectures with test enabled.
  3. The tests pass for all specs.

Yes, I have removed from the corresponding folders from SPECS-EXTENDED/

ausgaonkar avatar Nov 05 '22 04:11 ausgaonkar

The go-rpm-macros.spec is the only file that has %forgemeta macro. I could not locate any SPEC file that has %forgemeta macro. Hence, I am unable to resolve the spec-lint error. This link tells something about lua and how to handle. Can someone help on how to go about this?

@ameyapu Ameya Usgaonkar FTE, I've taken a look at this check and the problem is with running the check in Ubuntu, where it doesn't have Mariner's lua modules installed by mariner-rpm-macros. I'm working on a fix for the PR check to get you (and all future devs working with forgemeta macros unblocked. Sorry for the trouble!

I've pushed the fix to main. You might need to merge the latest main or rebase your changes on top of it to have the new check kick in. It maybe be also possible that just another commit to this PR will help - I am not entirely clear on how these PR checks run.

@PawelWMS - I am afraid your fix does not help as I still get errors regarding forgemeta. So, please help!

ausgaonkar avatar Nov 05 '22 08:11 ausgaonkar

The go-rpm-macros.spec is the only file that has %forgemeta macro. I could not locate any SPEC file that has %forgemeta macro. Hence, I am unable to resolve the spec-lint error. This link tells something about lua and how to handle. Can someone help on how to go about this?

@ameyapu

        Ameya Usgaonkar
        FTE Ameya Usgaonkar FTE, I've taken a look at this check and the problem is with running the check in Ubuntu, where it doesn't have Mariner's lua modules installed by `mariner-rpm-macros`. I'm working on a fix for the PR check to get you (and all future devs working with `forgemeta` macros unblocked. Sorry for the trouble!

I've pushed the fix to main. You might need to merge the latest main or rebase your changes on top of it to have the new check kick in. It maybe be also possible that just another commit to this PR will help - I am not entirely clear on how these PR checks run.

@PawelWMS Pawel Winogrodzki FTE - I am afraid your fix does not help as I still get errors regarding forgemeta. So, please help!

I am insanely sorry for the delay. I believe I see what still remains to be done. I'll send out another fix soon.

PawelWMS avatar Nov 08 '22 22:11 PawelWMS

The go-rpm-macros.spec is the only file that has %forgemeta macro. I could not locate any SPEC file that has %forgemeta macro. Hence, I am unable to resolve the spec-lint error. This link tells something about lua and how to handle. Can someone help on how to go about this?

@ameyapu

        Ameya Usgaonkar
        FTE Ameya Usgaonkar FTE, I've taken a look at this check and the problem is with running the check in Ubuntu, where it doesn't have Mariner's lua modules installed by `mariner-rpm-macros`. I'm working on a fix for the PR check to get you (and all future devs working with `forgemeta` macros unblocked. Sorry for the trouble!

I've pushed the fix to main. You might need to merge the latest main or rebase your changes on top of it to have the new check kick in. It maybe be also possible that just another commit to this PR will help - I am not entirely clear on how these PR checks run.

@PawelWMS Pawel Winogrodzki FTE - I am afraid your fix does not help as I still get errors regarding forgemeta. So, please help!

I am insanely sorry for the delay. I believe I see what still remains to be done. I'll send out another fix soon.

No worries! Do post an update here when the new PR gets pushed into main.

ausgaonkar avatar Nov 09 '22 02:11 ausgaonkar

The go-rpm-macros.spec is the only file that has %forgemeta macro. I could not locate any SPEC file that has %forgemeta macro. Hence, I am unable to resolve the spec-lint error. This link tells something about lua and how to handle. Can someone help on how to go about this?

@ameyapu

        Ameya Usgaonkar
        FTE Ameya Usgaonkar FTE, I've taken a look at this check and the problem is with running the check in Ubuntu, where it doesn't have Mariner's lua modules installed by `mariner-rpm-macros`. I'm working on a fix for the PR check to get you (and all future devs working with `forgemeta` macros unblocked. Sorry for the trouble!

I've pushed the fix to main. You might need to merge the latest main or rebase your changes on top of it to have the new check kick in. It maybe be also possible that just another commit to this PR will help - I am not entirely clear on how these PR checks run.

@PawelWMS Pawel Winogrodzki FTE - I am afraid your fix does not help as I still get errors regarding forgemeta. So, please help!

I am insanely sorry for the delay. I believe I see what still remains to be done. I'll send out another fix soon.

No worries! Do post an update here when the new PR gets pushed into main.

Just pushed the update. I tried it against go-rpm-macros.spec inside the PR and the check passed, so I have high hopes.

PawelWMS avatar Nov 09 '22 18:11 PawelWMS

A few clean-up request. Please also make sure that:

  1. We remove all duplicate spec folder from SPECS-EXTENDED.
  2. The moved packages build fine in the buddy build for both architectures with test enabled.
  3. The tests pass for all specs.

1a. Duplicate folders from SPECS-EXTENDED removed for corresponding packages brought into mainline. 2a. Buddy build with default settings successful for all the packages (see here) 3a. Spec and lint tests passing for all the packages

ausgaonkar avatar Nov 10 '22 04:11 ausgaonkar

The go-rpm-macros.spec is the only file that has %forgemeta macro. I could not locate any SPEC file that has %forgemeta macro. Hence, I am unable to resolve the spec-lint error. This link tells something about lua and how to handle. Can someone help on how to go about this?

@ameyapu

        Ameya Usgaonkar
        FTE Ameya Usgaonkar FTE, I've taken a look at this check and the problem is with running the check in Ubuntu, where it doesn't have Mariner's lua modules installed by `mariner-rpm-macros`. I'm working on a fix for the PR check to get you (and all future devs working with `forgemeta` macros unblocked. Sorry for the trouble!

I've pushed the fix to main. You might need to merge the latest main or rebase your changes on top of it to have the new check kick in. It maybe be also possible that just another commit to this PR will help - I am not entirely clear on how these PR checks run.

@PawelWMS Pawel Winogrodzki FTE - I am afraid your fix does not help as I still get errors regarding forgemeta. So, please help!

I am insanely sorry for the delay. I believe I see what still remains to be done. I'll send out another fix soon.

No worries! Do post an update here when the new PR gets pushed into main.

Just pushed the update. I tried it against go-rpm-macros.spec inside the PR and the check passed, so I have high hopes.

Thank you very much! All spec and lint checks are now passing. If there are no further review comments/feedback, please approve this PR.

ausgaonkar avatar Nov 10 '22 04:11 ausgaonkar

@neha170 / @PawelWMS - If there are no further review comments, please approve the PR.

ausgaonkar avatar Nov 10 '22 04:11 ausgaonkar

Thank you @PawelWMS and @neha170. I will build one final time in my local sandbox just to make sure that we are covered here.

ausgaonkar avatar Nov 11 '22 03:11 ausgaonkar