azurelinux icon indicating copy to clipboard operation
azurelinux copied to clipboard

Add RPM package dependencies to CDI components

Open ausgaonkar opened this issue 3 years ago • 1 comments

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • [x] The toolchain has been rebuilt successfully (or no changes were made to it)
  • [x] The toolchain/worker package manifests are up-to-date
  • [x] Any updated packages successfully build (or no packages were changed)
  • [x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • [x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • [x] All package sources are available
  • [x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • [x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • [x] All source files have up-to-date hashes in the *.signatures.json files
  • [x] sudo make go-tidy-all and sudo make go-test-coverage pass
  • [x] Documentation has been updated to match any changes to the build system
  • [x] Ready to merge

Summary

This PR uses the Requires directive of RPM specification to enforce dependent RPM packages that will form part of the final components from which golden containers are built. See bug 3349 for more details.

Change Log
  • Added dependent RPMs using the Requires directive
  • Included build of binaries from tools directory and into their corresponding sub-components
  • Updated release version and change log
Does this affect the toolchain?

NO

Associated issues
  • Link to successful buddy build is here.
Links to CVEs
  • https://nvd.nist.gov/vuln/detail/CVE-YYYY-XXXX
Test Methodology

ausgaonkar avatar Oct 28 '22 11:10 ausgaonkar

@oliviacrain / @romoh - Some changes have been done per review feedback. We will revisit this PR after merging nbdkit PR.

ausgaonkar avatar Nov 02 '22 11:11 ausgaonkar

@oliviacrain / @romoh - Some changes have been done per review feedback. We will revisit this PR after merging nbdkit PR.

@oliviacrain - With PR #4163 merged, it is time to revisit. Request to review the changes.

ausgaonkar avatar Nov 14 '22 06:11 ausgaonkar