azurelinux icon indicating copy to clipboard operation
azurelinux copied to clipboard

Remove DOWNLOAD_SRPMS flag and functionality

Open rlmenge opened this issue 3 years ago • 0 comments

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • [x] The toolchain has been rebuilt successfully (or no changes were made to it)
  • [x] The toolchain/worker package manifests are up-to-date
  • [x] Any updated packages successfully build (or no packages were changed)
  • [x] Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • [x] Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • [x] All package sources are available
  • [x] cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/tools/cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • [x] LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • [x] All source files have up-to-date hashes in the *.signatures.json files
  • [x] sudo make go-tidy-all and sudo make go-test-coverage pass
  • [x] Documentation has been updated to match any changes to the build system
  • [ ] Ready to merge

Summary

This flag is broken in 2.0. When we query for the spec name and version, the file can't be parsed due to new macros within 2.0 specs. These macros are resolved in the package mariner_macros but since we are building outside of a chroot, this package can't be loaded.

Remove this flag for now as there is not a strong need for it. Future fixes will require a chroot so that mariner_macros is present or loaded.

https://microsoft.visualstudio.com/OS/_workitems/edit/40942962

Change Log
  • Remove DOWNLOAD_SRPMS and associated flags
Does this affect the toolchain?

NO

Associated issues

https://microsoft.visualstudio.com/OS/_workitems/edit/40942962

Test Methodology

rlmenge avatar Oct 11 '22 17:10 rlmenge