azuredatastudio icon indicating copy to clipboard operation
azuredatastudio copied to clipboard

Update to Electron 30+

Open JustinGrote opened this issue 1 year ago • 1 comments

Azure Data studio is still running on electron 25. Electron 25 has been EOL for 9 months now and has several high and critical severity outstanding vulnerabilities that will never be fixed. Extensions such as the PowerShell extension that support Azure Data Studio also cannot update from the underlying nodejs version and are at risk for the same vulnerabilities.

Please consider updating to at least Electron 30.4.0 which is what the current version of VSCode uses, I imagine with that user base it has been proven stable enough :).

JustinGrote avatar Sep 24 '24 22:09 JustinGrote

For example, the PowerShell extension is forced to use these unsupported engines due to maintaining Azure Data Studio Support

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@vscode/[email protected]',
npm WARN EBADENGINE   required: { node: '>= 20' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.9.3' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '>=18.17' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.9.3' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.9.3' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.9.3' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.9.3' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.9.3' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '20 || >=22' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.9.3' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '>=18.17' },
npm WARN EBADENGINE   current: { node: 'v18.15.0', npm: '9.9.3' }
npm WARN EBADENGINE }

JustinGrote avatar Sep 24 '24 22:09 JustinGrote