azuredatastudio
azuredatastudio copied to clipboard
microsoft
missing inputs validation button fix
Pull Request Test Coverage Report for Build 8078650210
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
- For more information on this, see Tracking coverage changes with pull request builds.
- To avoid this issue with future PRs, see these Recommended CI Configurations.
- For a quick fix, rebase this PR at GitHub. Your next report should be accurate.
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage decreased (-0.001%) to 41.756%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| extensions/notebook/src/dialog/configurePython/configurePythonWizard.ts | 1 | 46.46% |
| <!-- | Total: | 1 |
| Totals | |
|---|---|
| Change from base Build 8076359343: | -0.001% |
| Covered Lines: | 30826 |
| Relevant Lines: | 69082 |
💛 - Coveralls
Looks good, but still these validations are just for field remains blank. is that sufficient?
@krritik as you suggested in call that you would take further validation in later release. You can go ahead with this for now.
Let's go with this implementation and we can cover other validation in next release
