azuredatastudio icon indicating copy to clipboard operation
azuredatastudio copied to clipboard

File Change Tracking No Longer Showing In Margins Since Recent Update

Open jonsteel95 opened this issue 1 year ago • 7 comments

Type: Bug

In the SQL text editor, when a change is made to a prior saved file, the line is no longer marked in the margins with a decoration / color. This is a big deal for editing production code.

I have ripped all of my settings / extensions out, uninstalled, reinstalled, to no avail.

Azure Data Studio version: azuredatastudio 1.45.1 (88c21b1725a3e79440027bdb7b5a55fb036be0e2, 2023-08-03T00:42:37.945Z) OS version: Windows_NT x64 10.0.19045 Restricted Mode: No Preview Features: Disabled Modes:

System Info
Item Value
CPUs Intel(R) Core(TM) i7-5930K CPU @ 3.50GHz (12 x 3500)
GPU Status 2d_canvas: unavailable_software
canvas_oop_rasterization: disabled_off
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: disabled_software
multiple_raster_threads: enabled_on
opengl: disabled_off
rasterization: disabled_software
raw_draw: disabled_off_ok
video_decode: disabled_software
video_encode: disabled_software
vulkan: disabled_off
webgl: unavailable_software
webgl2: unavailable_software
webgpu: unavailable_software
Load (avg) undefined
Memory (System) 63.91GB (48.88GB free)
Process Argv
Screen Reader no
VM 0%
Extensions: none

jonsteel95 avatar Aug 08 '23 17:08 jonsteel95

Confirming the issue is reproducible for 'SQL' file types.

cheenamalhotra avatar Aug 08 '23 20:08 cheenamalhotra

Preliminary research on this issue indicates it to be a flaw from VSCODE, this will need to be brought up to their team since this is a dependency issue technically.

smartguest avatar Aug 29 '23 22:08 smartguest

File Change Tracker in vscode only works when the file is part of an existing Git folder and not for isolated files randomly open not part of the project. I wonder if this is the case with ADS as well.

smartguest avatar Sep 11 '23 17:09 smartguest

It seems like the custom SQL editor that we are using is ignoring any changes made as part of file change tracking, I will have to see if the switchover to a new editor is causing the regression or not.

smartguest avatar Sep 11 '23 17:09 smartguest

Hello, and thank you for looking into this issue. For what it is worth, I noticed that I can force the decorations in the margin if I first open the "compare with saved" tab, and switch back to the original file tab.

jonsteel95 avatar Nov 10 '23 13:11 jonsteel95

Hello, and thank you for looking into this issue. For what it is worth, I noticed that I can force the decorations in the margin if I first open the "compare with saved" tab, and switch back to the original file tab.

same for me. but then the disappear again if i close the compare tab :(

did you ever figure out how to get them to always show?

wikge avatar Feb 06 '24 20:02 wikge

@kisantia @smartguest I'm disappointed, though admittedly selfishly, to see this issue prioritized down to Backlog as it's a major pain point for me currently. Is there anything I or others can do to help perhaps provide more meaningful logs to assist in drilling down on what the underlying issue may be?

CarbonChauvinist avatar Mar 25 '24 16:03 CarbonChauvinist