azuredatastudio icon indicating copy to clipboard operation
azuredatastudio copied to clipboard

Fixing Slick Grid accessibility bugs.

Open aasimkhan30 opened this issue 2 years ago • 8 comments

Issues: #19864, #19843, #19831

This PR also aligns the checkbox to the center of the cell: image image

When select active row is true, everytime the a cell is focused the focus then goes to the entire row. Example: azuredatastudio-insiders_uykTv5b1e9

After disabling it, the behavior becomes normal and expected. azuredatastudio_v59tA7R7py

Also, this PR needs to be updated to the latest version of ADS Slick to truly fix everything. The PR for that is over here. https://github.com/microsoft/SlickGrid.ADS/pull/7

aasimkhan30 avatar Aug 31 '22 01:08 aasimkhan30

I will tag other affected area owners to this PR after we the code is finalized.

aasimkhan30 avatar Aug 31 '22 01:08 aasimkhan30

the file name is checkboxSelectColumn2.plugin.ts, seriously? :) why not update the existing class?

alanrenmsft avatar Aug 31 '22 01:08 alanrenmsft

@aasimkhan30 - FYI I believe that the current expectation is that we're not supposed to close issues ourselves. The a11y team is the one that does that. So please remove the auto-close keywords from your description so they stay open.

Charles-Gagnon avatar Aug 31 '22 21:08 Charles-Gagnon

And is this ready for review? Please set it to draft if it's still in progress

Charles-Gagnon avatar Aug 31 '22 21:08 Charles-Gagnon

@aasimkhan30 please remove the auto-close tags as @Charles-Gagnon pointed out.

alanrenmsft avatar Sep 19 '22 17:09 alanrenmsft

please add description for the fixes as well as GIFs showing the differences.

alanrenmsft avatar Sep 19 '22 17:09 alanrenmsft

@alanrenmsft , updated description with gifs

aasimkhan30 avatar Sep 20 '22 15:09 aasimkhan30