azuredatastudio
azuredatastudio copied to clipboard
Fixing Slick Grid accessibility bugs.
Issues: #19864, #19843, #19831
This PR also aligns the checkbox to the center of the cell:
When select active row is true, everytime the a cell is focused the focus then goes to the entire row.
Example:
After disabling it, the behavior becomes normal and expected.
Also, this PR needs to be updated to the latest version of ADS Slick to truly fix everything. The PR for that is over here. https://github.com/microsoft/SlickGrid.ADS/pull/7
Pull Request Test Coverage Report for Build 3107540528
- 3 of 81 (3.7%) changed or added relevant lines in 3 files are covered.
- 1524 unchanged lines in 43 files lost coverage.
- Overall coverage increased (+0.4%) to 42.463%
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
---|---|---|---|
src/sql/workbench/browser/modelComponents/table.component.ts | 0 | 1 | 0.0% |
src/sql/base/browser/ui/table/table.ts | 0 | 3 | 0.0% |
src/sql/base/browser/ui/table/plugins/checkboxSelectColumn.plugin.ts | 3 | 77 | 3.9% |
<!-- | Total: | 3 | 81 |
Totals | |
---|---|
Change from base Build 2960444105: | 0.4% |
Covered Lines: | 29232 |
Relevant Lines: | 64061 |
💛 - Coveralls
I will tag other affected area owners to this PR after we the code is finalized.
the file name is checkboxSelectColumn2.plugin.ts
, seriously? :)
why not update the existing class?
@aasimkhan30 - FYI I believe that the current expectation is that we're not supposed to close issues ourselves. The a11y team is the one that does that. So please remove the auto-close keywords from your description so they stay open.
And is this ready for review? Please set it to draft if it's still in progress
@aasimkhan30 please remove the auto-close tags as @Charles-Gagnon pointed out.
please add description for the fixes as well as GIFs showing the differences.
@alanrenmsft , updated description with gifs