azuredatastudio
azuredatastudio copied to clipboard
microsoft
Fix for table component checkbox selection focus the previous active …
…row instead of newly checked row
This PR fixes #
- Table component row focus issue on checkbox selection. Issue: when a table has multiple rows with checkbox component and any checkbox is selected, the table is to focus the previously selected row, but it should select the recently selected row.
- This change fixes the problem with deployment options tab/ object type options tab in SC and SQL DB extensions, and SC diff window row selections. https://github.com/microsoft/azuredatastudio/issues/20202 https://github.com/microsoft/azuredatastudio/issues/16718 https://github.com/microsoft/azuredatastudio/issues/19674
https://user-images.githubusercontent.com/74571829/184026438-99d96879-5e1b-4d62-9b04-5b8e05c4755c.mp4
Pull Request Test Coverage Report for Build 2836660320
- 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.01%) to 41.693%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| src/sql/base/browser/ui/table/plugins/checkboxSelectColumn.plugin.ts | 0 | 1 | 0.0% |
| <!-- | Total: | 0 | 1 |
| Totals | |
|---|---|
| Change from base Build 2836465648: | 0.01% |
| Covered Lines: | 27838 |
| Relevant Lines: | 62212 |
💛 - Coveralls
is #20280 also fixed by this? Also, use "fixes" before the each of the issues mentioned in the description so that they get closed when this PR is merged :)
is #20280 also fixed by this? Also, use "fixes" before the each of the issues mentioned in the description so that they get closed when this PR is merged :)
This what we created yesterday, forgot to mention this one, thanks!
@chlafreniere /@alanrenmsft , I see couple of notebook tests are failing with this timeout, Do you know is there any issue with the pipelines?
@ssreerama please check the "Azure Data Studio - Product Build" pipeline. If the same tests are failing there from last night's build, you can safely assume that this isn't related and check in.
Gotcha! these failing tests are found in last run of "Azure Data Studio - Product Build" pipeline!