azuredatastudio
azuredatastudio copied to clipboard
microsoft
Edit Data Refresh PR
This PR addresses the add new row functionality such as hitting enter at the new row, makes commits when changing to a new row, fixes tab navigation, and finally adds features such as saving for dirty states upon closing (and saving cells in general). It also adds the function to preserve the last entered value in case of switching tabs or after an invalid edit and has general improvements to recovering from invalid edits. It also fixes the restore view state callback by disabling dispose on the grid until the Edit Data input is actually destroyed. Screenshots and more will come later.
Issues fixed will be listed below:
Pull Request Test Coverage Report for Build 3056602662
- 0 of 31 (0.0%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage decreased (-0.007%) to 42.032%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
|---|---|---|---|
| src/sql/workbench/browser/editData/editDataResultsInput.ts | 0 | 9 | 0.0% |
| src/sql/workbench/browser/editData/editDataInput.ts | 0 | 22 | 0.0% |
| <!-- | Total: | 0 | 31 |
| Totals | |
|---|---|
| Change from base Build 3055032271: | -0.007% |
| Covered Lines: | 28039 |
| Relevant Lines: | 62101 |
💛 - Coveralls
@smartguest should we close out this older PR since I think it will still need a bit of work to get merged? We can reopen later if we pick this back up.
