azuredatastudio icon indicating copy to clipboard operation
azuredatastudio copied to clipboard

Fix SQL Migration extension accessibility bugs

Open AkshayMata opened this issue 2 years ago • 4 comments

This PR fixes #19861, #19861 by adding aria labels

AkshayMata avatar Aug 08 '22 16:08 AkshayMata

CLA assistant check
All CLA requirements met.

ghost avatar Aug 08 '22 16:08 ghost

Pull Request Test Coverage Report for Build 2829685814

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 262 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.4%) to 41.684%

Files with Coverage Reduction New Missed Lines %
extensions/schema-compare/src/models/schemaCompareOptionsModel.ts 3 90.91%
extensions/sql-database-projects/src/models/options/deployOptionsModel.ts 7 79.55%
extensions/schema-compare/src/dialogs/schemaCompareOptionsDialog.ts 11 51.43%
extensions/sql-database-projects/src/common/utils.ts 17 85.11%
extensions/arc/src/ui/dashboards/miaa/miaaComputeAndStoragePage.ts 33 0%
extensions/sql-database-projects/src/dialogs/publishOptionsDialog.ts 33 51.46%
extensions/azcli/src/az.ts 69 23.41%
extensions/sql-database-projects/src/dialogs/publishDatabaseDialog.ts 89 52.42%
<!-- Total: 262
Totals Coverage Status
Change from base Build 2819378593: -0.4%
Covered Lines: 27832
Relevant Lines: 62205

💛 - Coveralls

coveralls avatar Aug 09 '22 23:08 coveralls

@AkshayMata do you need help merging the PR? is the merge button disabled for you?

alanrenmsft avatar Aug 10 '22 22:08 alanrenmsft

@alanrenmsft yes, I need help merging the PR. the merge button is disabled and I am getting a message that "Only those with write access to this repository can merge pull requests." I've requested to join the data-tools-contrib team to get write access.

AkshayMata avatar Aug 10 '22 22:08 AkshayMata