azuredatastudio icon indicating copy to clipboard operation
azuredatastudio copied to clipboard

A11y_Azure Data Studio extension 'Azure SQL Migration'_Network file share_ScreenReader: In network share path field, backslash(\) present in placeholder text is read twice.

Open NiharikaTipirishetty opened this issue 2 years ago • 5 comments

"Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

Github Tags:

#A11yMAS; #A11yTCS; #A11ySev3; #Benchmark; #SH-AzureSQLMigration-Win32-Jun2022; #DesktopApp; #Win32; #SQL Migration Control Plane; #WCAG1.3.1; #ScreenReader; #Narrator; #NVDA

Environment and OS details:

Azure Data Studio Version 1.37.0(User Setup) Windows Version 21H2 (OS Build 22000.675)

Note:

This issue is not observed with NVDA

Repro Steps:

  1. Turn on Narrator/NVDA
  2. Install Azure data studio app and install Azure SQL migration extension
  3. Connect to SQL server, tab till respective server, right click and select manage
  4. Tab till Azure SQL Migration in sitemap and press enter key
  5. Tab till migrate to azure sql and press enter
  6. Navigate to databases grid in "Databases for assessment", select few databases and click next.
  7. Tab till Network share path field in Database backup step for "My database backups are on a network share"
  8. Verify that backslash() present in placeholder text is read twice.

Actual Result:

In network share path field, backslash() present in placeholder text is read twice.

Expected Result:

In network share path field, backslash() present in placeholder text should read only once

Attachment:

Narrator_backslash NVDA_backslash

NiharikaTipirishetty avatar Jun 29 '22 12:06 NiharikaTipirishetty

need to fix NETWORK_SHARE_PATH_FORMAT. used \\ to escape in string, but narrator is reading without "escaping"

AkshayMata avatar Aug 08 '22 21:08 AkshayMata

our string constant is defined as:

export const NETWORK_SHARE_PATH_FORMAT = localize('sql.migration.network.share.path.format', "\\Servername.domainname.com\Backupfolder");

the placeholder text is properly being escaped, but this is leading to narrator reading \ out twice. @aasimkhan30 will ask to figure out how we can escape to satisfy those conditions

AkshayMata avatar Aug 08 '22 22:08 AkshayMata

@NiharikaTipirishetty, this is a narrator bug. We do not optimize for individual screen readers. Please close this issue.

aasimkhan30 avatar Aug 09 '22 02:08 aasimkhan30

Here in the Help text backslash () provided two times. Please find attachment for reference. MicrosoftTeams-image (3)

VijayaBharathyA avatar Aug 10 '22 03:08 VijayaBharathyA

Could you please provide Sample app to log an external bug to Narrator?

VijayaBharathyA avatar Sep 21 '22 06:09 VijayaBharathyA

The Chromium version 98 that is used in ads has an issue causing this bug. The latest one 106 does not have this issue. We can keep it open until ADS gets updated to that version.

aasimkhan30 avatar Oct 25 '22 17:10 aasimkhan30

@VijayaBharathyA this issue appears to be an ADS core / component issue and not related to the SQL-Migration extension.
I'm closing this bug. Please create a 3rd party issue/bug with the above context mentioned, assign it to the ADS team noting that this will be fixed with a Chromium version upgrade.

Based on comments above, this issue is known by the ADS team and should not require a repro/samples.

brian-harris avatar Apr 19 '23 15:04 brian-harris